atol and rtol in isapprox
#122
Conversation
Codecov ReportBase: 86.09% // Head: 86.10% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #122 +/- ##
=======================================
Coverage 86.09% 86.10%
=======================================
Files 31 31
Lines 2496 2497 +1
=======================================
+ Hits 2149 2150 +1
Misses 347 347
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
Throwing an error when comparing open and closed domains seems like a sensible thing to do. Type-piracy aside, I think we should update DomainSets accordingly. |
|
Removing this method from |
|
Sure, we can make version 0.6. I think @dlfivefifty is looking at this issue in #123 so I won't touch anything. |
|
Perfect. I would suggest making a Edit: Sorry, it seems the method is not overwritten after all. Only the |
|
Note this is now in IntervalSets.jl: JuliaMath/IntervalSets.jl#125 I think throwing an error makes no sense; see my PR JuliaMath/IntervalSets.jl#129 |
|
Meanwhile, that definition seems to have disappeared. I have also removed the tests for approximate equality of intervals, since that is defined and tested in IntervalSets. We still have to implement/improve isapprox more generally for domains. |
3 participants
This adds
atolandrtolparameters to theisapproxdefined here. This method is committing type-piracy here (and perhaps harms pre-compilation, as it is overwriting the other method), so perhaps this should be removed in a future breaking version. The breakage comes from the fact that theisapproxdefined inIntervalSetsthrows an error when comparing closed and open intervals, whereas this version doesn't.